Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2052663004: Remove canScroll from WebMouseWheelEvent as it is unused now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix android unit test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/render_widget_input_handler.cc
diff --git a/content/renderer/input/render_widget_input_handler.cc b/content/renderer/input/render_widget_input_handler.cc
index 7a427303a4524558049836dcab19d3dc0ec1b451..fc320d91a068e0bd514722c49464f0d500bb7d72 100644
--- a/content/renderer/input/render_widget_input_handler.cc
+++ b/content/renderer/input/render_widget_input_handler.cc
@@ -387,21 +387,11 @@ void RenderWidgetInputHandler::HandleInputEvent(
}
}
- // Send mouse wheel events and their disposition to the compositor thread, so
- // that they can be used to produce the elastic overscroll effect on Mac.
- if (input_event.type == WebInputEvent::MouseWheel) {
- const WebMouseWheelEvent& wheel_event =
- static_cast<const WebMouseWheelEvent&>(input_event);
- if (wheel_event.canScroll) {
- delegate_->ObserveWheelEventAndResult(
- wheel_event,
- event_overscroll ? event_overscroll->latest_overscroll_delta
- : gfx::Vector2dF(),
- processed != WebInputEventResult::NotHandled);
- }
- } else if (input_event.type == WebInputEvent::GestureScrollBegin ||
- input_event.type == WebInputEvent::GestureScrollEnd ||
- input_event.type == WebInputEvent::GestureScrollUpdate) {
+ // Send gesture scroll events and their dispositions to the compositor thread,
+ // so that they can be used to produce the elastic overscroll effect on Mac.
+ if (input_event.type == WebInputEvent::GestureScrollBegin ||
+ input_event.type == WebInputEvent::GestureScrollEnd ||
+ input_event.type == WebInputEvent::GestureScrollUpdate) {
const WebGestureEvent& gesture_event =
static_cast<const WebGestureEvent&>(input_event);
if (gesture_event.sourceDevice == blink::WebGestureDeviceTouchpad) {
« no previous file with comments | « content/common/input/web_input_event_traits_unittest.cc ('k') | mojo/converters/blink/blink_input_events_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698