Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*

Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/adef4a59be3e3a5fec0277dc255731f56fe8665d
Cr-Commit-Position: refs/heads/master@{#398964}

[ncarter (slow), 2016-06-08 20:46:55]

Description was changed from

==========
Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.

BUG=None
==========

to

==========
Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-06-08 23:18:17]

nick@chromium.org changed reviewers:
+ avi@chromium.org

[ncarter (slow), 2016-06-08 23:18:18]

Hi avi,

What do you think of making ToRenderFrameHost even more magical? It comes at a
cost of being more magical.

[Avi (use Gerrit), 2016-06-09 02:11:17]

I'm the one who introduced that magic, so I'm ok with more magic.

LGTM

https://codereview.chromium.org/2052633002/diff/80001/content/public/test/con...
File content/public/test/content_browser_test_utils.cc (right):

https://codereview.chromium.org/2052633002/diff/80001/content/public/test/con...
content/public/test/content_browser_test_utils.cc:20: #include
"content/shell/browser/shell.h"
It didn't occur to me that we had this dependency. :O

[ncarter (slow), 2016-06-09 16:24:09]

https://codereview.chromium.org/2052633002/diff/80001/content/public/test/con...
File content/public/test/content_browser_test_utils.cc (right):

https://codereview.chromium.org/2052633002/diff/80001/content/public/test/con...
content/public/test/content_browser_test_utils.cc:20: #include
"content/shell/browser/shell.h"
On 2016/06/09 02:11:17, Avi (OOO 12 June - 25 June) wrote:
> It didn't occur to me that we had this dependency. :O

It's legit. Only content_browsertests (and component browsertests that are
content-shell based) are supposed to include this file. 

The matrix of "what utils #includes are allowed where" is pretty
testwriter-unfriendly, IMO:

  test_utils
  browser_test_utils
  content_browser_test_utils
  content_test_utils
  content_browser_test_utils_internal

I kind of wish we would just #include the allowed util files from
browser_test_base.h and content_browser_test.h or something like that, IWYU be
damned. The approach I'm switching to makes this scenario worse, because using
ToRenderFrameHost with an FTN requires you to have included the right file for
the FTN variant of ConvertToRenderFrameHost.

[ncarter (slow), 2016-06-09 16:32:25]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-06-09 16:33:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052633002/80001

[commit-bot: I haz the power, 2016-06-09 18:46:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-09 18:46:14]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 18:48:13]

Description was changed from

==========
Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/adef4a59be3e3a5fec0277dc255731f56fe8665d
Cr-Commit-Position: refs/heads/master@{#398964}
==========

[commit-bot: I haz the power, 2016-06-09 18:48:14]

Patchset 5 (id:??) landed as
https://crrev.com/adef4a59be3e3a5fec0277dc255731f56fe8665d
Cr-Commit-Position: refs/heads/master@{#398964}