content/browser/top_document_isolation_browsertest.cc - Issue 2052633002: Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/top_document_isolation_browsertest.cc

Issue 2052633002: Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix induced script bug. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/browser/web_contents/opened_by_dom_browsertest.cc » ('j') | content/public/test/content_browser_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/top_document_isolation_browsertest.cc

diff --git a/content/browser/top_document_isolation_browsertest.cc b/content/browser/top_document_isolation_browsertest.cc

index 72d87060f4cfb686561dab8c9dcc57a6f3c68db5..bca52ee136668dde5490ca319ac181a6667af153 100644

--- a/content/browser/top_document_isolation_browsertest.cc

+++ b/content/browser/top_document_isolation_browsertest.cc

@@ -55,13 +55,13 @@ class TopDocumentIsolationTest : public ContentBrowserTest {

Shell* OpenPopup(FrameTreeNode* opener, const std::string& url) {

GURL gurl =

opener->current_frame_host()->GetLastCommittedURL().Resolve(url);

- return content::OpenPopup(opener->current_frame_host(), gurl, "_blank");

+ return content::OpenPopup(opener, gurl, "_blank");

}

void RendererInitiatedNavigateToURL(FrameTreeNode* node, const GURL& url) {

TestFrameNavigationObserver nav_observer(node);

- ASSERT_TRUE(ExecuteScript(node->current_frame_host(),

- "window.location.href='" + url.spec() + "'"));

+ ASSERT_TRUE(

+ ExecuteScript(node, "window.location.href='" + url.spec() + "'"));

nav_observer.Wait();

}