Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: content/browser/manifest/manifest_browsertest.cc

Issue 2052633002: Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix induced script bug. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/manifest/manifest_browsertest.cc
diff --git a/content/browser/manifest/manifest_browsertest.cc b/content/browser/manifest/manifest_browsertest.cc
index bcac10714853d01f9273f1f8445a3a49f103c464..cc6a90586026cb829a97dc57153bbf4e15fd6a3f 100644
--- a/content/browser/manifest/manifest_browsertest.cc
+++ b/content/browser/manifest/manifest_browsertest.cc
@@ -247,7 +247,7 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, DynamicManifest) {
std::string manifest_url =
GetTestUrl("manifest", "dummy-manifest.json").spec();
ASSERT_TRUE(content::ExecuteScript(
- shell()->web_contents(), "setManifestTo('" + manifest_url + "')"));
+ shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
EXPECT_FALSE(manifest().IsEmpty());
@@ -260,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, DynamicManifest) {
std::string manifest_url =
GetTestUrl("manifest", "empty-manifest.json").spec();
ASSERT_TRUE(content::ExecuteScript(
- shell()->web_contents(), "setManifestTo('" + manifest_url + "')"));
+ shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
EXPECT_TRUE(manifest().IsEmpty());
@@ -290,8 +290,8 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, CORSManifest) {
std::string manifest_url = cors_embedded_test_server()->GetURL(
"/manifest/dummy-manifest.json").spec();
- ASSERT_TRUE(content::ExecuteScript(shell()->web_contents(),
- "setManifestTo('" + manifest_url + "')"));
+ ASSERT_TRUE(
+ content::ExecuteScript(shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
EXPECT_TRUE(manifest().IsEmpty());
@@ -308,8 +308,8 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, CORSManifest) {
// it is actually fully loaded.
manifest_url =
embedded_test_server()->GetURL("/manifest/dummy-manifest.json").spec();
- ASSERT_TRUE(content::ExecuteScript(shell()->web_contents(),
- "setManifestTo('" + manifest_url + "')"));
+ ASSERT_TRUE(
+ content::ExecuteScript(shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
}
@@ -330,8 +330,8 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, CORSManifestWithAcessControls) {
std::string manifest_url = cors_embedded_test_server()->GetURL(
"/manifest/manifest-cors.json").spec();
- ASSERT_TRUE(content::ExecuteScript(shell()->web_contents(),
- "setManifestTo('" + manifest_url + "')"));
+ ASSERT_TRUE(
+ content::ExecuteScript(shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
EXPECT_FALSE(manifest().IsEmpty());
@@ -360,8 +360,8 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, MixedContentManifest) {
std::string manifest_url =
https_server->GetURL("/manifest/dummy-manifest.json").spec();
- ASSERT_TRUE(content::ExecuteScript(shell()->web_contents(),
- "setManifestTo('" + manifest_url + "')"));
+ ASSERT_TRUE(
+ content::ExecuteScript(shell(), "setManifestTo('" + manifest_url + "')"));
GetManifestAndWait();
EXPECT_TRUE(manifest().IsEmpty());
@@ -441,8 +441,7 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, PushStateNavigation) {
{
TestNavigationObserver navigation_observer(shell()->web_contents(), 1);
ASSERT_TRUE(content::ExecuteScript(
- shell()->web_contents(),
- "history.pushState({foo: \"bar\"}, 'page', 'page.html');"));
+ shell(), "history.pushState({foo: \"bar\"}, 'page', 'page.html');"));
navigation_observer.Wait();
}
@@ -470,7 +469,7 @@ IN_PROC_BROWSER_TEST_F(ManifestBrowserTest, AnchorNavigation) {
{
TestNavigationObserver navigation_observer(shell()->web_contents(), 1);
ASSERT_TRUE(content::ExecuteScript(
- shell()->web_contents(),
+ shell(),
"var a = document.createElement('a'); a.href='#foo';"
"document.body.appendChild(a); a.click();"));
navigation_observer.Wait();

Powered by Google App Engine
This is Rietveld 408576698