content/browser/browser_side_navigation_browsertest.cc - Issue 2052633002: Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_side_navigation_browsertest.cc

Issue 2052633002: Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix induced script bug. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bookmarklet_browsertest.cc ('k') | content/browser/cross_site_transfer_browsertest.cc » ('j') | content/public/test/content_browser_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_side_navigation_browsertest.cc

diff --git a/content/browser/browser_side_navigation_browsertest.cc b/content/browser/browser_side_navigation_browsertest.cc

index eaaff0537aff3cf2e997c97344d2a6258d9dca87..b6d27f09f82400ba04e8df88c43b13216d84d579 100644

--- a/content/browser/browser_side_navigation_browsertest.cc

+++ b/content/browser/browser_side_navigation_browsertest.cc

@@ -106,8 +106,8 @@ IN_PROC_BROWSER_TEST_F(BrowserSideNavigationBrowserTest,

GURL url(embedded_test_server()->GetURL("/title2.html"));

bool success = false;

EXPECT_TRUE(ExecuteScriptAndExtractBool(

- shell()->web_contents(),

- "window.domAutomationController.send(clickSameSiteLink());", &success));

+ shell(), "window.domAutomationController.send(clickSameSiteLink());",

+ &success));

EXPECT_TRUE(success);

EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));

EXPECT_EQ(url, observer.last_navigation_url());

@@ -145,13 +145,11 @@ IN_PROC_BROWSER_TEST_F(BrowserSideNavigationBrowserTest,

GURL url = embedded_test_server()->GetURL("foo.com", "/title2.html");

bool success = false;

EXPECT_TRUE(ExecuteScriptAndExtractBool(

- shell()->web_contents(),

- base::StringPrintf(kReplacePortNumber, port_number),

+ shell(), base::StringPrintf(kReplacePortNumber, port_number),

&success));

success = false;

EXPECT_TRUE(ExecuteScriptAndExtractBool(

- shell()->web_contents(),

- "window.domAutomationController.send(clickCrossSiteLink());",

+ shell(), "window.domAutomationController.send(clickCrossSiteLink());",

&success));

EXPECT_TRUE(success);

EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));