Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: extensions/common/event_filter_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/event_filter_unittest.cc
diff --git a/extensions/common/event_filter_unittest.cc b/extensions/common/event_filter_unittest.cc
index 8ab266cb680ab6d0a3652dce78b1d79651d88146..b2a351a14f1096a2edc4587c45373bfe72bef7b9 100644
--- a/extensions/common/event_filter_unittest.cc
+++ b/extensions/common/event_filter_unittest.cc
@@ -39,7 +39,7 @@ class EventFilterUnittest : public testing::Test {
std::unique_ptr<base::ListValue> ValueAsList(
std::unique_ptr<base::Value> value) {
std::unique_ptr<base::ListValue> result(new base::ListValue());
- result->Append(value.release());
+ result->Append(std::move(value));
return result;
}
@@ -139,8 +139,8 @@ TEST_F(EventFilterUnittest, TestURLMatching) {
TEST_F(EventFilterUnittest, TestMultipleURLFiltersMatchOnAny) {
std::unique_ptr<base::ListValue> filters(new base::ListValue());
- filters->Append(HostSuffixDict("google.com").release());
- filters->Append(HostSuffixDict("yahoo.com").release());
+ filters->Append(HostSuffixDict("google.com"));
+ filters->Append(HostSuffixDict("yahoo.com"));
std::unique_ptr<EventMatcher> matcher(
MatcherFromURLFilterList(std::move(filters)));

Powered by Google App Engine
This is Rietveld 408576698