content/browser/indexed_db/indexed_db_context_impl.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_context_impl.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/about_signin_internals.cc ('k') | content/renderer/devtools/v8_sampling_profiler_browsertest.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_context_impl.cc

diff --git a/content/browser/indexed_db/indexed_db_context_impl.cc b/content/browser/indexed_db/indexed_db_context_impl.cc

index ec67dd2474e65233ce27742c5c6a0cd8a9228a12..8ec55b0c040a62e1dec9c0da73600d02ee9ae1e3 100644

--- a/content/browser/indexed_db/indexed_db_context_impl.cc

+++ b/content/browser/indexed_db/indexed_db_context_impl.cc

@@ -266,16 +266,16 @@ base::ListValue* IndexedDBContextImpl::GetAllOriginsDetails() {

}

transaction_info->Set("scope", scope.release());

- transaction_list->Append(transaction_info.release());

+ transaction_list->Append(std::move(transaction_info));

}

db_info->Set("transactions", transaction_list.release());

- database_list->Append(db_info.release());

+ database_list->Append(std::move(db_info));

}

info->Set("databases", database_list.release());

}

- list->Append(info.release());

+ list->Append(std::move(info));

}

return list.release();

}