Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/snapshot/snapshot-source-sink.h

Issue 2051043003: [snapshot] pass arguments as pointers, not references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@snapshotcreator
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/snapshot/snapshot-common.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_ 5 #ifndef V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_
6 #define V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_ 6 #define V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_
7 7
8 #include "src/base/logging.h" 8 #include "src/base/logging.h"
9 #include "src/utils.h" 9 #include "src/utils.h"
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 void PutSection(int b, const char* description) { 88 void PutSection(int b, const char* description) {
89 DCHECK_LE(b, kMaxUInt8); 89 DCHECK_LE(b, kMaxUInt8);
90 Put(static_cast<byte>(b), description); 90 Put(static_cast<byte>(b), description);
91 } 91 }
92 92
93 void PutInt(uintptr_t integer, const char* description); 93 void PutInt(uintptr_t integer, const char* description);
94 void PutRaw(const byte* data, int number_of_bytes, const char* description); 94 void PutRaw(const byte* data, int number_of_bytes, const char* description);
95 int Position() { return data_.length(); } 95 int Position() { return data_.length(); }
96 96
97 const List<byte>& data() const { return data_; } 97 const List<byte>* data() const { return &data_; }
98 98
99 private: 99 private:
100 List<byte> data_; 100 List<byte> data_;
101 }; 101 };
102 102
103 } // namespace internal 103 } // namespace internal
104 } // namespace v8 104 } // namespace v8
105 105
106 #endif // V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_ 106 #endif // V8_SNAPSHOT_SNAPSHOT_SOURCE_SINK_H_
OLDNEW
« no previous file with comments | « src/snapshot/snapshot-common.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698