src/snapshot/snapshot-source-sink.h - Issue 2051043003: [snapshot] pass arguments as pointers, not references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/snapshot-source-sink.h

Issue 2051043003: [snapshot] pass arguments as pointers, not references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@snapshotcreator

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/snapshot/snapshot-source-sink.h

diff --git a/src/snapshot/snapshot-source-sink.h b/src/snapshot/snapshot-source-sink.h

index 360ec76bb61986deabbfd20d156dd120ce34fd50..5d4c08d43a04681892377333796562072a71dc7f 100644

--- a/src/snapshot/snapshot-source-sink.h

+++ b/src/snapshot/snapshot-source-sink.h

@@ -94,7 +94,7 @@ class SnapshotByteSink {

void PutRaw(const byte* data, int number_of_bytes, const char* description);

int Position() { return data_.length(); }

- const List<byte>& data() const { return data_; }

+ const List<byte>* data() const { return &data_; }

private:

List<byte> data_;

« no previous file with comments | « src/snapshot/snapshot-common.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »