Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2048533002: Add code and key into the browser test key simulation methods. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add code and key into the browser test key simulation methods. With the soon to be removal of keyboardIdentifier it is necessary that events generated from the test suites actually have the correct key value. BUG=607349 Committed: https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0 Cr-Commit-Position: refs/heads/master@{#398385}

Patch Set 1 #

Patch Set 2 : Fix interactive tests #

Patch Set 3 : Fix chromeos build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -223 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 1 4 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 18 chunks +77 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_interactive_uitest.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/browser/site_per_process_interactive_browsertest.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 2 chunks +4 lines, -62 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +6 lines, -22 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 3 chunks +40 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
dtapuska
On 2016/06/07 14:17:19, dtapuska wrote: > mailto:dtapuska@chromium.org changed reviewers: > + mailto:jochen@chromium.org PTAL; I've got ...
4 years, 6 months ago (2016-06-07 14:18:32 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-07 19:09:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048533002/40001
4 years, 6 months ago (2016-06-07 19:32:04 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-07 21:40:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 21:41:43 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0
Cr-Commit-Position: refs/heads/master@{#398385}

Powered by Google App Engine
This is Rietveld 408576698