chrome/browser/chromeos/input_method/textinput_browsertest.cc - Issue 2048533002: Add code and key into the browser test key simulation methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/textinput_browsertest.cc

Issue 2048533002: Add code and key into the browser test key simulation methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autofill_interactive_uitest.cc ('k') | chrome/browser/password_manager/password_manager_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/textinput_browsertest.cc

diff --git a/chrome/browser/chromeos/input_method/textinput_browsertest.cc b/chrome/browser/chromeos/input_method/textinput_browsertest.cc

index ec62c9cd5f34e6b6b9a470182f25f0e67b35309f..6ba6f32c56c3c6f151c5ed3fe547661ed2fe94c9 100644

--- a/chrome/browser/chromeos/input_method/textinput_browsertest.cc

+++ b/chrome/browser/chromeos/input_method/textinput_browsertest.cc

@@ -257,7 +257,8 @@ IN_PROC_BROWSER_TEST_F(TextInput_TextInputStateChangedTest,

}; // The order should be same as tab order in all_input_node.html.

for (size_t i = 0; i < arraysize(expectations); ++i) {

- content::SimulateKeyPress(tab, ui::VKEY_TAB, false, false, false, false);

+ content::SimulateKeyPress(tab, ui::DomKey::TAB, ui::DomCode::TAB,

+ ui::VKEY_TAB, false, false, false, false);

helper.WaitForTextInputStateChanged(expectations[i].type);

EXPECT_EQ(expectations[i].type, helper.GetTextInputType());