chrome/browser/password_manager/password_manager_interactive_uitest.cc - Issue 2048533002: Add code and key into the browser test key simulation methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 2048533002: Add code and key into the browser test key simulation methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/textinput_browsertest.cc ('k') | chrome/browser/site_per_process_interactive_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_manager_interactive_uitest.cc b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

index 748b230db826005ca2006726292b7feec37667f7..3f5b1230b87597895a6f18c5a69ba7d965bdb66d 100644

--- a/chrome/browser/password_manager/password_manager_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

@@ -20,15 +20,20 @@ void SimulateUserTypingInField(content::RenderViewHost* render_view_host,

std::string focus("document.getElementById('" + field_id + "').focus();");

ASSERT_TRUE(content::ExecuteScript(render_view_host, focus));

- content::SimulateKeyPress(web_contents, ui::VKEY_O, false, false, false,

+ content::SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('O'),

+ ui::DomCode::US_O, ui::VKEY_O, false, false, false,

false);

- content::SimulateKeyPress(web_contents, ui::VKEY_R, false, false, false,

+ content::SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('R'),

+ ui::DomCode::US_R, ui::VKEY_R, false, false, false,

false);

- content::SimulateKeyPress(web_contents, ui::VKEY_A, false, false, false,

+ content::SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('A'),

+ ui::DomCode::US_A, ui::VKEY_A, false, false, false,

false);

- content::SimulateKeyPress(web_contents, ui::VKEY_R, false, false, false,

+ content::SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('R'),

+ ui::DomCode::US_R, ui::VKEY_R, false, false, false,

false);

- content::SimulateKeyPress(web_contents, ui::VKEY_Y, false, false, false,

+ content::SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('Y'),

+ ui::DomCode::US_Y, ui::VKEY_Y, false, false, false,

false);

}