chrome/browser/site_per_process_interactive_browsertest.cc - Issue 2048533002: Add code and key into the browser test key simulation methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/site_per_process_interactive_browsertest.cc

Issue 2048533002: Add code and key into the browser test key simulation methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_interactive_uitest.cc ('k') | chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/site_per_process_interactive_browsertest.cc

diff --git a/chrome/browser/site_per_process_interactive_browsertest.cc b/chrome/browser/site_per_process_interactive_browsertest.cc

index dd2c5230e747423e021a76d708936aace1fa732c..590ef78e297781f362b1805d3e88878c118df792 100644

--- a/chrome/browser/site_per_process_interactive_browsertest.cc

+++ b/chrome/browser/site_per_process_interactive_browsertest.cc

@@ -150,9 +150,12 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,

EXPECT_EQ(child, web_contents->GetFocusedFrame());

// Generate a few keyboard events and route them to currently focused frame.

- SimulateKeyPress(web_contents, ui::VKEY_F, false, false, false, false);

- SimulateKeyPress(web_contents, ui::VKEY_O, false, false, false, false);

+ SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('f'),

+ ui::DomCode::US_F, ui::VKEY_F, false, false, false, false);

+ SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('O'),

+ ui::DomCode::US_O, ui::VKEY_O, false, false, false, false);

+ SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('O'),

+ ui::DomCode::US_O, ui::VKEY_O, false, false, false, false);

// Verify that the input field in the subframe received the keystrokes.

EXPECT_TRUE(ExecuteScriptAndExtractString(

@@ -220,8 +223,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,

auto press_tab_and_wait_for_message = [web_contents](bool reverse) {

content::DOMMessageQueue msg_queue;

std::string reply;

- SimulateKeyPress(web_contents, ui::VKEY_TAB, false, reverse /* shift */,

- false, false);

+ SimulateKeyPress(web_contents, ui::DomKey::TAB, ui::DomCode::TAB,

+ ui::VKEY_TAB, false, reverse /* shift */, false, false);

EXPECT_TRUE(msg_queue.WaitForMessage(&reply));

return reply;

};