Added telemetry pages for the canvas element.

Added telemetry pages for the canvas element.

BUG=606687, 606686, 606685
Committed: https://crrev.com/c0a7ab42ca62bf097d879cc298ee1e97121463eb
Cr-Commit-Position: refs/heads/master@{#399039}

[sebastienlc, 2016-06-07 19:46:08]

Description was changed from

==========
Added telemetry pages for the canvas element.

BUG=
==========

to

==========
Added telemetry pages for the canvas element.

BUG=
==========

[sebastienlc, 2016-06-07 19:46:08]

sebastienlc@google.com changed reviewers:
+ junov@chromium.org, senorblanco@chromium.org, sullivan@chromium.org

[sullivan, 2016-06-07 20:27:07]

lgtm

owner LGTM but please also wait for Stephen or Justin.

[Justin Novosad, 2016-06-08 17:14:22]

Cleanup a few test that are now obsolete. Otherwise lgtm.

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_canvas_cases.py (right):

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:73:
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=canvas_sprite&back=canvas',
Get rid of this one, which is now redundant.

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:77:
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=filled_path&back=gradient',
This one too

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:83:
'file://../../../chrome/test/data/perf/canvas_bench/single_image.html',
This one too

[sebastienlc, 2016-06-08 19:06:28]

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_canvas_cases.py (right):

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:73:
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=canvas_sprite&back=canvas',
On 2016/06/08 17:14:21, Justin Novosad wrote:
> Get rid of this one, which is now redundant.

Done.

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:77:
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=filled_path&back=gradient',
On 2016/06/08 17:14:21, Justin Novosad wrote:
> This one too

Done.

https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_canvas_cases.py:83:
'file://../../../chrome/test/data/perf/canvas_bench/single_image.html',
On 2016/06/08 17:14:21, Justin Novosad wrote:
> This one too

Done.

[Justin Novosad, 2016-06-08 19:43:29]

On 2016/06/08 19:06:28, sebastienlc wrote:
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> File tools/perf/page_sets/tough_canvas_cases.py (right):
> 
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> tools/perf/page_sets/tough_canvas_cases.py:73:
>
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=canvas_sprite&back=canvas',
> On 2016/06/08 17:14:21, Justin Novosad wrote:
> > Get rid of this one, which is now redundant.
> 
> Done.
> 
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> tools/perf/page_sets/tough_canvas_cases.py:77:
>
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=filled_path&back=gradient',
> On 2016/06/08 17:14:21, Justin Novosad wrote:
> > This one too
> 
> Done.
> 
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> tools/perf/page_sets/tough_canvas_cases.py:83:
> 'file://../../../chrome/test/data/perf/canvas_bench/single_image.html',
> On 2016/06/08 17:14:21, Justin Novosad wrote:
> > This one too
> 
> Done.

Please also delete the files for single_image.html

[sebastienlc, 2016-06-09 17:21:42]

On 2016/06/08 19:43:29, Justin Novosad wrote:
> On 2016/06/08 19:06:28, sebastienlc wrote:
> >
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> > File tools/perf/page_sets/tough_canvas_cases.py (right):
> > 
> >
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> > tools/perf/page_sets/tough_canvas_cases.py:73:
> >
>
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=canvas_sprite&back=canvas',
> > On 2016/06/08 17:14:21, Justin Novosad wrote:
> > > Get rid of this one, which is now redundant.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> > tools/perf/page_sets/tough_canvas_cases.py:77:
> >
>
'file://tough_canvas_cases/canvas2d_balls_common/bouncing_balls.html?ball=filled_path&back=gradient',
> > On 2016/06/08 17:14:21, Justin Novosad wrote:
> > > This one too
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2047773002/diff/1/tools/perf/page_sets/tough_...
> > tools/perf/page_sets/tough_canvas_cases.py:83:
> > 'file://../../../chrome/test/data/perf/canvas_bench/single_image.html',
> > On 2016/06/08 17:14:21, Justin Novosad wrote:
> > > This one too
> > 
> > Done.
> 
> Please also delete the files for single_image.html

We talked about this in person and decided to leave single_image.html there.

[Justin Novosad, 2016-06-09 17:25:25]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-06-09 17:25:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2047773002/#ps80001
(title: "Undo previous patch")

[commit-bot: I haz the power, 2016-06-09 17:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047773002/80001

[commit-bot: I haz the power, 2016-06-09 17:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 17:28:41]

Try jobs failed on following builders:
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebastienlc, 2016-06-09 19:39:00]

The CQ bit was checked by sebastienlc@google.com

[sebastienlc, 2016-06-09 19:39:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2047773002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 19:39:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047773002/100001

[commit-bot: I haz the power, 2016-06-09 19:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 19:42:57]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebastienlc, 2016-06-09 20:14:54]

The CQ bit was checked by sebastienlc@google.com

[sebastienlc, 2016-06-09 20:14:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2047773002/#ps120001
(title: "Removed png image")

[commit-bot: I haz the power, 2016-06-09 20:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047773002/120001

[commit-bot: I haz the power, 2016-06-09 20:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 20:23:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sebastienlc, 2016-06-09 20:38:08]

Description was changed from

==========
Added telemetry pages for the canvas element.

BUG=
==========

to

==========
Added telemetry pages for the canvas element.

BUG=606687,606686,606685
==========

[sebastienlc, 2016-06-09 21:11:12]

The CQ bit was checked by sebastienlc@google.com

[sebastienlc, 2016-06-09 21:11:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2047773002/#ps140001
(title: "Some formatting")

[commit-bot: I haz the power, 2016-06-09 21:11:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047773002/140001

[commit-bot: I haz the power, 2016-06-09 22:36:34]

Description was changed from

==========
Added telemetry pages for the canvas element.

BUG=606687,606686,606685
==========

to

==========
Added telemetry pages for the canvas element.

BUG=606687,606686,606685
==========

[commit-bot: I haz the power, 2016-06-09 22:36:35]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-09 22:36:55]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 22:38:06]

Description was changed from

==========
Added telemetry pages for the canvas element.

BUG=606687,606686,606685
==========

to

==========
Added telemetry pages for the canvas element.

BUG=606687,606686,606685

Committed: https://crrev.com/c0a7ab42ca62bf097d879cc298ee1e97121463eb
Cr-Commit-Position: refs/heads/master@{#399039}
==========

[commit-bot: I haz the power, 2016-06-09 22:38:07]

Patchset 8 (id:??) landed as
https://crrev.com/c0a7ab42ca62bf097d879cc298ee1e97121463eb
Cr-Commit-Position: refs/heads/master@{#399039}