Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools

Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools

This is enough for this to work OK:

[gn-2013]d:\src\cr\src>gn gen out_gn
[gn-2013]d:\src\cr\src>ninja -C out_gn gn
[gn-2013]d:\src\cr\src>out_gn\gn gen out_gn2
[gn-2013]d:\src\cr\src>ninja -C out_gn2 gn
...
[297/297] LINK gn.exe

I'm not sure if we need all the deleted stuff for something
else, but I guess we can revive it when we need it.

(There's some dependency problem with linking atm, as
"ninja -C out_gn gn" always relinks, but I think it's unrelated.)

R=brettw@chromium.org
BUG=297677
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258327

[brettw, 2014-03-20 05:46:22]

lgtm

https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_...
File build/config/win/visual_studio_version.gni (right):

https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_...
build/config/win/visual_studio_version.gni:6: # Path to Visual Studio. In
Chrome, this is the depot_tools toolchain.
Can you document that empty means to use the default.

[scottmg, 2014-03-20 16:01:17]

https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_...
File build/config/win/visual_studio_version.gni (right):

https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_...
build/config/win/visual_studio_version.gni:6: # Path to Visual Studio. In
Chrome, this is the depot_tools toolchain.
On 2014/03/20 05:46:22, brettw wrote:
> Can you document that empty means to use the default.

Done.

[scottmg, 2014-03-20 17:46:22]

Committed patchset #3 manually as r258327 (presubmit successful).

[tfarina, 2014-03-20 17:48:02]

Hum, "ninja -C out_gn gn" always relinks", I think we should investigate.

Do you mind filing a bug for this?

[scottmg, 2014-03-20 18:25:43]

On 2014/03/20 17:48:02, tfarina wrote:
> Hum, "ninja -C out_gn gn" always relinks", I think we should investigate.
> 
> Do you mind filing a bug for this?

I looked into it. It's because there's the manifest is getting regenerated, so
there's a changed input.

i.e. it's only after

  gn gen out_gn
  ninja -C out_gn gn

not just with repeated

  ninja -C out_gn gn