Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools This is enough for this to work OK: [gn-2013]d:\src\cr\src>gn gen out_gn [gn-2013]d:\src\cr\src>ninja -C out_gn gn [gn-2013]d:\src\cr\src>out_gn\gn gen out_gn2 [gn-2013]d:\src\cr\src>ninja -C out_gn2 gn ... [297/297] LINK gn.exe I'm not sure if we need all the deleted stuff for something else, but I guess we can revive it when we need it. (There's some dependency problem with linking atm, as "ninja -C out_gn gn" always relinks, but I think it's unrelated.) R=brettw@chromium.org BUG=297677 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258327

Patch Set 1 #

Patch Set 2 : Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools #

Total comments: 2

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -874 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download
D build/config/win/get_msvc_config.py View 1 1 chunk +0 lines, -77 lines 0 comments Download
D build/config/win/get_msvc_config_real.py View 1 1 chunk +0 lines, -575 lines 0 comments Download
D build/config/win/get_visual_studio_path.py View 1 1 chunk +0 lines, -176 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 1 2 1 chunk +11 lines, -25 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/toolchain/win/setup_toolchain.py View 1 3 chunks +18 lines, -11 lines 0 comments Download
M build/vs_toolchain.py View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 9 months ago (2014-03-19 22:45:02 UTC) #1
brettw
lgtm https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_studio_version.gni File build/config/win/visual_studio_version.gni (right): https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_studio_version.gni#newcode6 build/config/win/visual_studio_version.gni:6: # Path to Visual Studio. In Chrome, this ...
6 years, 9 months ago (2014-03-20 05:46:22 UTC) #2
scottmg
https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_studio_version.gni File build/config/win/visual_studio_version.gni (right): https://codereview.chromium.org/204663004/diff/10001/build/config/win/visual_studio_version.gni#newcode6 build/config/win/visual_studio_version.gni:6: # Path to Visual Studio. In Chrome, this is ...
6 years, 9 months ago (2014-03-20 16:01:17 UTC) #3
scottmg
Committed patchset #3 manually as r258327 (presubmit successful).
6 years, 9 months ago (2014-03-20 17:46:22 UTC) #4
tfarina
Hum, "ninja -C out_gn gn" always relinks", I think we should investigate. Do you mind ...
6 years, 9 months ago (2014-03-20 17:48:02 UTC) #5
scottmg
6 years, 9 months ago (2014-03-20 18:25:43 UTC) #6
Message was sent while issue was closed.
On 2014/03/20 17:48:02, tfarina wrote:
> Hum, "ninja -C out_gn gn" always relinks", I think we should investigate.
> 
> Do you mind filing a bug for this?

I looked into it. It's because there's the manifest is getting regenerated, so
there's a changed input.

i.e. it's only after

  gn gen out_gn
  ninja -C out_gn gn

not just with repeated

  ninja -C out_gn gn

Powered by Google App Engine
This is Rietveld 408576698