Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Side by Side Diff: build/config/win/visual_studio_version.gni

Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/win/get_visual_studio_path.py ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Version of Visual Studio to use. 6 # Path to Visual Studio. In Chrome, this is the depot_tools toolchain.
brettw 2014/03/20 05:46:22 Can you document that empty means to use the defau
scottmg 2014/03/20 16:01:18 Done.
7 # 7 visual_studio_path = ""
8 # Possible values:
9 # - "auto"
10 # - "2010"
11 # - "2010e"
12 # - "2012"
13 # - "2012e"
14 # - "2013"
15 # - "2013e"
16 #
17 # The "e" variants denote "Express". The default, "auto" will find the
18 # preferred one of all Visual Studios installed on the current system.
19 visual_studio_version = "auto"
20 8
21 # The path to use as the root of a Visual Studio install. If nonempty, 9 # Full path to the Windows SDK, not including a backslash at the end.
22 # this path will be used instead of any autodetected install locations, 10 # This value is the default location, override if you have a different
23 # which allows you to have the Visual Studio files in a directory without 11 # installation location.
24 # actually "installing" it. 12 windows_sdk_path = "C:\Program Files (x86)\Windows Kits\8.0"
25 #
26 # When empty, we will autodetect the best Visual Studio path to use. The
27 # autodetected one is usually something like
28 # "C:\Program Files (x86)\Microsoft Visual Studio 10.0".
29 visual_studio_path = ""
30 } 13 }
31 14
32 if (visual_studio_path == "") { 15 if (visual_studio_path == "") {
33 visual_studio_path = exec_script("get_visual_studio_path.py", 16 toolchain_data =
34 [ visual_studio_version ], "value") 17 exec_script("../../vs_toolchain.py", [ "get_toolchain_dir" ], "value")
18 visual_studio_path = toolchain_data[0]
19 windows_sdk_path = toolchain_data[1]
35 } 20 }
36 21
OLDNEW
« no previous file with comments | « build/config/win/get_visual_studio_path.py ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698