build/toolchain/win/BUILD.gn - Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index c35ec45adcd69fc2ba694d538c22e623fff48d4c..2a9a96c0fdf176131180a600e71c1b81b32ce266 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -16,7 +16,8 @@ import("//build/config/win/visual_studio_version.gni")

# list to us.

gyp_win_tool_path = rebase_path("//tools/gyp/pylib/gyp/win_tool.py",

root_build_dir)

-exec_script("setup_toolchain.py", [ visual_studio_path, gyp_win_tool_path ],

+exec_script("setup_toolchain.py",

+ [ visual_studio_path, gyp_win_tool_path, windows_sdk_path ],

"string")

stamp_command = "$python_path gyp-win-tool stamp \$out"

« no previous file with comments | « build/config/win/visual_studio_version.gni ('k') | build/toolchain/win/setup_toolchain.py » ('j') | no next file with comments »