build/config/win/BUILD.gn - Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 204663004: Use depot_tools toolchain, remove now unneeded code, fix not including path to win sdk tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index 39a05013f1533d24b94a2552b29f0cfc6c706ba4..3175b163bb70d093df607f6cd3200e278b9f50dc 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -4,13 +4,6 @@

import("//build/config/win/visual_studio_version.gni")

-declare_args() {

- # Full path to the Windows SDK, not including a backslash at the end.

- # This value is the default location, override if you have a different

- # installation location.

- windows_sdk_path = "C:\Program Files (x86)\Windows Kits\8.0"

# Compiler setup for the Windows SDK. Applied to all targets.

config("sdk") {

# The include path is the stuff returned by the script.

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/win/get_msvc_config.py » ('j') | no next file with comments »