Screen Orientation: use OrientationLockType enum for lockOrientation().

Screen Orientation: use OrientationLockType enum for lockOrientation().

BUG=162827
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169972

[abarth-chromium, 2014-03-19 17:14:14]

lgtm

[commit-bot: I haz the power, 2014-03-19 17:14:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/204653002/1

[commit-bot: I haz the power, 2014-03-19 17:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 17:14:51]

Failed to apply patch for
Source/modules/screen_orientation/ScreenOrientation.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/screen_orientation/ScreenOrientation.idl
  Hunk #1 FAILED at 9.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/modules/screen_orientation/ScreenOrientation.idl.rej

Patch:       Source/modules/screen_orientation/ScreenOrientation.idl
Index: Source/modules/screen_orientation/ScreenOrientation.idl
diff --git a/Source/modules/screen_orientation/ScreenOrientation.idl
b/Source/modules/screen_orientation/ScreenOrientation.idl
index
461ff7ae23ad7ba8f69798202d918cfaaef17464..7bb1b2d4d95a153866066ec82460e256eeda48da
100644
--- a/Source/modules/screen_orientation/ScreenOrientation.idl
+++ b/Source/modules/screen_orientation/ScreenOrientation.idl
@@ -9,12 +9,22 @@ enum OrientationType {
     "landscape-secondary"
 };
 
+enum OrientationLockType {
+    "any",
+    "landscape",
+    "portrait",
+    "portrait-primary",
+    "portrait-secondary",
+    "landscape-primary",
+    "landscape-secondary"
+};
+
 [
     RuntimeEnabled=ScreenOrientation
 ] partial interface Screen {
     [RaisesException] readonly attribute OrientationType orientation;
 
-    boolean lockOrientation(DOMString orientation);
+    boolean lockOrientation(OrientationLockType orientation);
 
     void unlockOrientation();
     attribute EventHandler onorientationchange;

[mlamouri (slow - plz ping), 2014-03-24 14:34:22]

This CL depends on this other CL: https://codereview.chromium.org/207833003/

Hopefully, the dependency will land soon.

[mlamouri (slow - plz ping), 2014-03-25 11:41:04]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-03-25 11:41:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/204653002/20001

[commit-bot: I haz the power, 2014-03-25 12:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 12:09:29]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[mlamouri (slow - plz ping), 2014-03-25 17:18:47]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-03-25 17:18:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/204653002/40001

[commit-bot: I haz the power, 2014-03-25 18:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 18:02:18]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[mlamouri (slow - plz ping), 2014-03-25 18:03:25]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-03-25 18:03:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/204653002/40001

[commit-bot: I haz the power, 2014-03-25 18:54:20]

Change committed as 169972