Source/modules/screen_orientation/ScreenOrientation.cpp - Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@screen_orientation_type

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-basic-expected.txt ('k') | Source/modules/screen_orientation/ScreenOrientation.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientation.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientation.cpp b/Source/modules/screen_orientation/ScreenOrientation.cpp

index 6bf1ba750c008f061f4a73ba971e859456cd3409..51c609a4e5f5bc9e4251695415cd0473b18db431 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientation.cpp

@@ -53,9 +53,14 @@ static const AtomicString& orientationToString(blink::WebScreenOrientation orien

static blink::WebScreenOrientations stringToOrientations(const AtomicString& orientationString)

{

+ DEFINE_STATIC_LOCAL(const AtomicString, any, ("any", AtomicString::ConstructFromLiteral));

DEFINE_STATIC_LOCAL(const AtomicString, portrait, ("portrait", AtomicString::ConstructFromLiteral));

DEFINE_STATIC_LOCAL(const AtomicString, landscape, ("landscape", AtomicString::ConstructFromLiteral));

+ if (orientationString == any) {

+ return blink::WebScreenOrientationPortraitPrimary | blink::WebScreenOrientationPortraitSecondary |

+ blink::WebScreenOrientationLandscapePrimary | blink::WebScreenOrientationLandscapeSecondary;

+ }

if (orientationString == portrait)

return blink::WebScreenOrientationPortraitPrimary | blink::WebScreenOrientationPortraitSecondary;

if (orientationString == landscape)