LayoutTests/screen_orientation/lockOrientation-basic.html - Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/lockOrientation-basic.html

Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@screen_orientation_type

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-basic-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/lockOrientation-basic.html

diff --git a/LayoutTests/screen_orientation/lockOrientation-basic.html b/LayoutTests/screen_orientation/lockOrientation-basic.html

index c54226dccc79f78ac099b7bb625cba2ac86e4dc3..a14ae787e6523faa97a433a2c332e2b0fba20ba4 100644

--- a/LayoutTests/screen_orientation/lockOrientation-basic.html

+++ b/LayoutTests/screen_orientation/lockOrientation-basic.html

@@ -7,9 +7,14 @@ description("Basic screen.lockOrientation() / screen.unlockOrientation() testing

shouldBeEqualToString("screen.orientation", "portrait-primary");

shouldNotThrow("screen.unlockOrientation()");

-shouldBeTrue("screen.lockOrientation('landscape-primary')");

-shouldBeEqualToString("screen.orientation", "portrait-primary"); // Should update asynchronously.

-shouldBeTrue("screen.lockOrientation('landscape-secondary')"); // Consecutive locking.

+[ 'any', 'portrait', 'landscape', 'portrait-primary', 'portrait-secondary',

+ 'landscape-primary', 'landscape-secondary' ].forEach(function(orientation) {

+ shouldBeTrue("screen.lockOrientation('" + orientation + "')");

+});

+// Update is made asynchronously so that shouldn't change.

+shouldBeEqualToString("screen.orientation", "portrait-primary");

shouldNotThrow("screen.unlockOrientation()");

</script>

</body>