LayoutTests/screen_orientation/lockOrientation-basic.html - Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/lockOrientation-basic.html

Issue 204653002: Screen Orientation: use OrientationLockType enum for lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@screen_orientation_type

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-basic-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 <script>	5 <script>

6 description("Basic screen.lockOrientation() / screen.unlockOrientation() testing ");	6 description("Basic screen.lockOrientation() / screen.unlockOrientation() testing ");

7	7

8 shouldBeEqualToString("screen.orientation", "portrait-primary");	8 shouldBeEqualToString("screen.orientation", "portrait-primary");

9 shouldNotThrow("screen.unlockOrientation()");	9 shouldNotThrow("screen.unlockOrientation()");

10 shouldBeTrue("screen.lockOrientation('landscape-primary')");	10

11 shouldBeEqualToString("screen.orientation", "portrait-primary"); // Should updat e asynchronously.	11 [ 'any', 'portrait', 'landscape', 'portrait-primary', 'portrait-secondary',

12 shouldBeTrue("screen.lockOrientation('landscape-secondary')"); // Consecutive lo cking.	12 'landscape-primary', 'landscape-secondary' ].forEach(function(orientation) {

	13 shouldBeTrue("screen.lockOrientation('" + orientation + "')");

	14 });

	15

	16 // Update is made asynchronously so that shouldn't change.

	17 shouldBeEqualToString("screen.orientation", "portrait-primary");

13 shouldNotThrow("screen.unlockOrientation()");	18 shouldNotThrow("screen.unlockOrientation()");

14 </script>	19 </script>

15 </body>	20 </body>

16 </html>	21 </html>

OLD	NEW