Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebScrollbarThemeClientImpl should not be DisplayItemClient WebScrollbarThemeClientImpl inherited DisplayItemClient from ScrollbarThemeClient but it is never used as a DisplayItemClient. Let Scrollbar instead of ScrollbarThemeClient inherit DisplayItemClient, and use Scrollbar type in ScrollbarTheme paint methods. This avoids the need to let WebScrollbarThemeClientImpl follow the rules of DisplayItemClient caching. Committed: https://crrev.com/ac0330544bb3294a5df1aa94fb0cd7c896804e11 Cr-Commit-Position: refs/heads/master@{#398818}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -64 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutScrollbarTheme.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarTheme.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Xianzhu
4 years, 6 months ago (2016-06-08 16:35:20 UTC) #3
chrishtr
lgtm
4 years, 6 months ago (2016-06-09 02:08:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045963003/20001
4 years, 6 months ago (2016-06-09 02:08:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/200814)
4 years, 6 months ago (2016-06-09 05:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045963003/20001
4 years, 6 months ago (2016-06-09 05:41:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 08:55:24 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 08:57:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac0330544bb3294a5df1aa94fb0cd7c896804e11
Cr-Commit-Position: refs/heads/master@{#398818}

Powered by Google App Engine
This is Rietveld 408576698