third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm - Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

index e671ec2bc72bc7bf267a22cce8dc70adb80e8753..510a473e1d87aec7008e3c7f24371bfaaca7a674 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

@@ -137,7 +137,7 @@ ScrollbarTheme& ScrollbarTheme::nativeTheme()

return overlayTheme;

}

-void ScrollbarThemeMac::paintGivenTickmarks(SkCanvas* canvas, const ScrollbarThemeClient& scrollbar, const IntRect& rect, const Vector<IntRect>& tickmarks)

+void ScrollbarThemeMac::paintGivenTickmarks(SkCanvas* canvas, const Scrollbar& scrollbar, const IntRect& rect, const Vector<IntRect>& tickmarks)

{

if (scrollbar.orientation() != VerticalScrollbar)

return;

@@ -176,7 +176,7 @@ void ScrollbarThemeMac::paintGivenTickmarks(SkCanvas* canvas, const ScrollbarThe

}

-void ScrollbarThemeMac::paintTickmarks(GraphicsContext& context, const ScrollbarThemeClient& scrollbar, const IntRect& rect)

+void ScrollbarThemeMac::paintTickmarks(GraphicsContext& context, const Scrollbar& scrollbar, const IntRect& rect)

{

// Note: This is only used for css-styled scrollbars on mac.

if (scrollbar.orientation() != VerticalScrollbar)

@@ -293,7 +293,7 @@ ScrollbarPainter ScrollbarThemeMac::painterForScrollbar(const ScrollbarThemeClie

return [scrollbarPainterMap().get(const_cast<ScrollbarThemeClient*>(&scrollbar)).get() painter];

}

-void ScrollbarThemeMac::paintTrackBackground(GraphicsContext& context, const ScrollbarThemeClient& scrollbar, const IntRect& rect) {

+void ScrollbarThemeMac::paintTrackBackground(GraphicsContext& context, const Scrollbar& scrollbar, const IntRect& rect) {

if (DrawingRecorder::useCachedDrawingIfPossible(context, scrollbar, DisplayItem::ScrollbarTrackBackground))

return;

@@ -311,7 +311,7 @@ void ScrollbarThemeMac::paintTrackBackground(GraphicsContext& context, const Scr

[scrollbarPainter drawKnobSlotInRect:trackRect highlight:NO];

}

-void ScrollbarThemeMac::paintThumb(GraphicsContext& context, const ScrollbarThemeClient& scrollbar, const IntRect& rect) {

+void ScrollbarThemeMac::paintThumb(GraphicsContext& context, const Scrollbar& scrollbar, const IntRect& rect) {

if (DrawingRecorder::useCachedDrawingIfPossible(context, scrollbar, DisplayItem::ScrollbarThumb))

return;