third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp - Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

index e33d72715be566b361d3220b8026f4dfbb7532ab..aac9bb4255313c6870002f840f5ac9720a846230 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

@@ -34,7 +34,7 @@

#include "platform/graphics/paint/DrawingDisplayItem.h"

#include "platform/graphics/paint/DrawingRecorder.h"

#include "platform/graphics/paint/PaintController.h"

-#include "platform/scroll/ScrollbarThemeClient.h"

+#include "platform/scroll/Scrollbar.h"

#include "platform/scroll/ScrollbarThemeMock.h"

#include "platform/scroll/ScrollbarThemeOverlayMock.h"

#include "public/platform/Platform.h"

@@ -56,7 +56,7 @@ static inline bool shouldPaintScrollbarPart(const IntRect& partRect, const CullR

return (!partRect.isEmpty()) || cullRect.intersectsCullRect(partRect);

}

-bool ScrollbarTheme::paint(const ScrollbarThemeClient& scrollbar, GraphicsContext& graphicsContext, const CullRect& cullRect)

+bool ScrollbarTheme::paint(const Scrollbar& scrollbar, GraphicsContext& graphicsContext, const CullRect& cullRect)

{

// Create the ScrollbarControlPartMask based on the cullRect

ScrollbarControlPartMask scrollMask = NoPart;