third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp - Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp

Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp

index 53cb1288d581adae41b05f873bfe0278096466db..faa26e70d0fcb9be6abeda753e7b9dbe6e38f7d2 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp

@@ -28,7 +28,7 @@

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/graphics/GraphicsContext.h"

#include "platform/graphics/paint/DrawingRecorder.h"

-#include "platform/scroll/ScrollbarThemeClient.h"

+#include "platform/scroll/Scrollbar.h"

namespace blink {

@@ -49,7 +49,7 @@ IntRect ScrollbarThemeMock::trackRect(const ScrollbarThemeClient& scrollbar, boo

return scrollbar.frameRect();

}

-void ScrollbarThemeMock::paintTrackBackground(GraphicsContext& context, const ScrollbarThemeClient& scrollbar, const IntRect& trackRect)

+void ScrollbarThemeMock::paintTrackBackground(GraphicsContext& context, const Scrollbar& scrollbar, const IntRect& trackRect)

{

if (DrawingRecorder::useCachedDrawingIfPossible(context, scrollbar, DisplayItem::ScrollbarTrackBackground))

return;

@@ -58,7 +58,7 @@ void ScrollbarThemeMock::paintTrackBackground(GraphicsContext& context, const Sc

context.fillRect(trackRect, scrollbar.enabled() ? Color::lightGray : Color(0xFFE0E0E0));

}

-void ScrollbarThemeMock::paintThumb(GraphicsContext& context, const ScrollbarThemeClient& scrollbar, const IntRect& thumbRect)

+void ScrollbarThemeMock::paintThumb(GraphicsContext& context, const Scrollbar& scrollbar, const IntRect& thumbRect)

{

if (!scrollbar.enabled())

return;