Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi> (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GetHash and friends: return a raw pointer instead of Handle<Smi> In most cases we return a Smi and undefined for the other cases. Hence there is no need to handlify the result unecessary. Additionally pass in the isolate for the hash-symbol lookup. BUG= Committed: https://crrev.com/d84fe42108081a55edea62cad305a7903ba16a3b Cr-Commit-Position: refs/heads/master@{#36790}

Patch Set 1 #

Patch Set 2 : rebasing again.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -96 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 4 chunks +10 lines, -16 lines 0 comments Download
M src/objects.cc View 1 3 chunks +57 lines, -55 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +14 lines, -13 lines 0 comments Download
M src/runtime/runtime-collections.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M test/cctest/test-dictionary.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Camillo Bruni
PTAL some more micro optimizations + cleanups
4 years, 6 months ago (2016-06-07 09:46:18 UTC) #2
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-06-07 12:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044843002/1
4 years, 6 months ago (2016-06-07 12:49:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6860) v8_presubmit on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 12:51:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044843002/40001
4 years, 6 months ago (2016-06-07 13:23:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-07 13:51:18 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:51:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d84fe42108081a55edea62cad305a7903ba16a3b
Cr-Commit-Position: refs/heads/master@{#36790}

Powered by Google App Engine
This is Rietveld 408576698