src/runtime/runtime-collections.cc - Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-collections.cc

Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebasing again.... Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-collections.cc

diff --git a/src/runtime/runtime-collections.cc b/src/runtime/runtime-collections.cc

index 4a7248324e652b3ae74f05e838ace0a91e49f3a7..8da822817eed1114901bbd0312f6c29a52c9c0ca 100644

--- a/src/runtime/runtime-collections.cc

+++ b/src/runtime/runtime-collections.cc

@@ -40,8 +40,8 @@ RUNTIME_FUNCTION(Runtime_GenericHash) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);

CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);

- Handle<Smi> hash = Object::GetOrCreateHash(isolate, object);

- return *hash;

+ Smi* hash = Object::GetOrCreateHash(isolate, object);

+ return hash;

}

« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »