src/api.cc - Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebasing again.... Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 759bd8b40e878e56f74f8822178e8826e1a75dc3..348724d9f04eaee3f27365a3e851ec42ef89a4b6 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4344,7 +4344,7 @@ int v8::Object::GetIdentityHash() {

auto isolate = Utils::OpenHandle(this)->GetIsolate();

i::HandleScope scope(isolate);

auto self = Utils::OpenHandle(this);

- return i::JSReceiver::GetOrCreateIdentityHash(self)->value();

+ return i::JSReceiver::GetOrCreateIdentityHash(isolate, self)->value();

}

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »