Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: src/objects-inl.h

Issue 2044843002: GetHash and friends: return a raw pointer instead of Handle<Smi> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebasing again.... Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-collections.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 3b336dfb3ebfa32438f20a342b17f3ff80625397..cb787374c81378898ba0f13c204776fa6b719eae 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -7249,19 +7249,20 @@ bool JSGlobalProxy::IsDetachedFrom(JSGlobalObject* global) const {
return iter.GetCurrent() != global;
}
-
-Handle<Smi> JSReceiver::GetOrCreateIdentityHash(Handle<JSReceiver> object) {
- return object->IsJSProxy()
- ? JSProxy::GetOrCreateIdentityHash(Handle<JSProxy>::cast(object))
- : JSObject::GetOrCreateIdentityHash(Handle<JSObject>::cast(object));
-}
-
-Handle<Object> JSReceiver::GetIdentityHash(Isolate* isolate,
- Handle<JSReceiver> receiver) {
- return receiver->IsJSProxy() ? JSProxy::GetIdentityHash(
- isolate, Handle<JSProxy>::cast(receiver))
- : JSObject::GetIdentityHash(
- isolate, Handle<JSObject>::cast(receiver));
+Smi* JSReceiver::GetOrCreateIdentityHash(Isolate* isolate,
+ Handle<JSReceiver> object) {
+ return object->IsJSProxy() ? JSProxy::GetOrCreateIdentityHash(
+ isolate, Handle<JSProxy>::cast(object))
+ : JSObject::GetOrCreateIdentityHash(
+ isolate, Handle<JSObject>::cast(object));
+}
+
+Object* JSReceiver::GetIdentityHash(Isolate* isolate,
+ Handle<JSReceiver> receiver) {
+ return receiver->IsJSProxy()
+ ? JSProxy::GetIdentityHash(Handle<JSProxy>::cast(receiver))
+ : JSObject::GetIdentityHash(isolate,
+ Handle<JSObject>::cast(receiver));
}
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-collections.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698