👔 Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata

Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
BUG=607169, 617213, 616155
Committed: https://crrev.com/d4d66d4d0353020ddf9f1423d08cf39ed911c329
Cr-Commit-Position: refs/heads/master@{#398601}

[agrieve, 2016-06-07 14:07:49]

Created Reland of 👔 Reland of Move side-loaded test data /sdcard ->
/sdcard/gtestdata

[agrieve, 2016-06-07 14:20:40]

Description was changed from

==========
Reland of 👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata
(patchset #1 id:1 of https://codereview.chromium.org/2044523003/ )

Reason for revert:
Will update desc when fixed

Original issue's description:
> Revert of Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata
(patchset #3 id:300001 of https://codereview.chromium.org/2018663002/ )
> 
> Reason for revert:
> Breaking quota-related tests in content_browsertests
> https://crbug.com/617213
> 
> Original issue's description:
> > Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
> >
> > Reason for reland:
> > Updated webview tests that broke (WebViewLayoutTest.java)
> >
> > And use delete_device_stale=True when pushing. This will prevent tests
> > mistakenly passing when they depend on stale data files from a previous
test.
> >
> > TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
> > BUG=607169
> >
> > Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> > Cr-Commit-Position: refs/heads/master@{#396479}
> 
>
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=607169,617213,616155
> 
> Committed: https://crrev.com/55ff9438e11da5a78a6ba5d100cebfcfdbc07deb
> Cr-Commit-Position: refs/heads/master@{#398137}

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607169,617213,616155
==========

to

==========
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata 

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
BUG=607169,617213,616155
==========

[agrieve, 2016-06-07 14:20:40]

agrieve@chromium.org changed reviewers:
+ johnme@chromium.org

[agrieve, 2016-06-07 14:22:29]

jbudorick - please have a quick look at the changes since last time. They are
just in: ContentBrowserTestsActivity.java, ComponentsBrowserTestsActivity.java

[jbudorick, 2016-06-07 14:31:02]

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
File base/test/test_support_android.cc (right):

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
base/test/test_support_android.cc:142: case base::DIR_ANDROID_APP_DATA:
Hm, the salient bit of code here is
https://codesearch.chromium.org/chromium/src/content/shell/browser/shell_brow...,
which uses $DIR_ANDROID_APP_DATA/content_shell/. Should we let this stay as the
external storage directory & only change DIR_SOURCE_ROOT? If not, what do you
envision the eventual solution being?

[agrieve, 2016-06-07 14:46:24]

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
File base/test/test_support_android.cc (right):

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
base/test/test_support_android.cc:142: case base::DIR_ANDROID_APP_DATA:
On 2016/06/07 14:31:01, jbudorick wrote:
> Hm, the salient bit of code here is
>
https://codesearch.chromium.org/chromium/src/content/shell/browser/shell_brow...,
> which uses $DIR_ANDROID_APP_DATA/content_shell/. Should we let this stay as
the
> external storage directory & only change DIR_SOURCE_ROOT? If not, what do you
> envision the eventual solution being?

Responded to this comment here:
https://bugs.chromium.org/p/chromium/issues/detail?id=617734

[jbudorick, 2016-06-07 15:05:48]

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
File base/test/test_support_android.cc (right):

https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
base/test/test_support_android.cc:142: case base::DIR_ANDROID_APP_DATA:
On 2016/06/07 14:46:24, agrieve wrote:
> On 2016/06/07 14:31:01, jbudorick wrote:
> > Hm, the salient bit of code here is
> >
>
https://codesearch.chromium.org/chromium/src/content/shell/browser/shell_brow...,
> > which uses $DIR_ANDROID_APP_DATA/content_shell/. Should we let this stay as
> the
> > external storage directory & only change DIR_SOURCE_ROOT? If not, what do
you
> > envision the eventual solution being?
> 
> Responded to this comment here:
> https://bugs.chromium.org/p/chromium/issues/detail?id=617734

Replied there too. Not sure either will work.

[agrieve, 2016-06-08 15:45:07]

On 2016/06/07 15:05:48, jbudorick wrote:
>
https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
> File base/test/test_support_android.cc (right):
> 
>
https://codereview.chromium.org/2043803003/diff/320001/base/test/test_support...
> base/test/test_support_android.cc:142: case base::DIR_ANDROID_APP_DATA:
> On 2016/06/07 14:46:24, agrieve wrote:
> > On 2016/06/07 14:31:01, jbudorick wrote:
> > > Hm, the salient bit of code here is
> > >
> >
>
https://codesearch.chromium.org/chromium/src/content/shell/browser/shell_brow...,
> > > which uses $DIR_ANDROID_APP_DATA/content_shell/. Should we let this stay
as
> > the
> > > external storage directory & only change DIR_SOURCE_ROOT? If not, what do
> you
> > > envision the eventual solution being?
> > 
> > Responded to this comment here:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=617734
> 
> Replied there too. Not sure either will work.

me too.

[jbudorick, 2016-06-08 15:49:11]

lgtm

[jbudorick, 2016-06-08 15:49:30]

On 2016/06/08 15:49:11, jbudorick wrote:
> lgtm

(and thanks for the explanation)

[agrieve, 2016-06-08 15:55:38]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-08 15:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043803003/320001

[commit-bot: I haz the power, 2016-06-08 16:53:54]

Description was changed from

==========
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata 

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
BUG=607169,617213,616155
==========

to

==========
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata 

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
BUG=607169,617213,616155
==========

[commit-bot: I haz the power, 2016-06-08 16:53:55]

Committed patchset #3 (id:320001)

[commit-bot: I haz the power, 2016-06-08 16:56:59]

Description was changed from

==========
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata 

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
BUG=607169,617213,616155
==========

to

==========
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata

Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.

Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromiu...
BUG=607169,617213,616155

Committed: https://crrev.com/d4d66d4d0353020ddf9f1423d08cf39ed911c329
Cr-Commit-Position: refs/heads/master@{#398601}
==========

[commit-bot: I haz the power, 2016-06-08 16:57:01]

Patchset 3 (id:??) landed as
https://crrev.com/d4d66d4d0353020ddf9f1423d08cf39ed911c329
Cr-Commit-Position: refs/heads/master@{#398601}