👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata

Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
Cr-Commit-Position: refs/heads/master@{#396479}

[agrieve, 2016-05-26 20:45:13]

Created Reland of 👔  Move side-loaded test data /sdcard -> /sdcard/gtestdata

[agrieve, 2016-05-26 20:49:30]

Description was changed from

==========
Reland of 👔  Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset
#1 id:1 of https://codereview.chromium.org/2011763007/ )

Reason for revert:
will update once fixed.

Original issue's description:
> Revert of 👔  Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset
#17 id:320001 of https://codereview.chromium.org/1926793002/ )
> 
> Reason for revert:
> Broke webview tests:
>
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%...
> 
> Original issue's description:
> > Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
> >
> > And use delete_device_stale=True when pushing. This will prevent tests
> > mistakenly passing when they depend on stale data files from a previous
test.
> >
> > BUG=607169
> >
> > Committed: https://crrev.com/0fe567512193cc8fbfcfd006ff1d504bd6346290
> > Cr-Commit-Position: refs/heads/master@{#396169}
> 
> TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=607169
> 
> Committed: https://crrev.com/5a7a6cd176bd3c1a9524893801b8d177ebe0f63a
> Cr-Commit-Position: refs/heads/master@{#396174}

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607169
==========

to

==========
Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
==========

[agrieve, 2016-05-26 20:51:15]

On 2016/05/26 20:45:13, agrieve wrote:
> Created Reland of 👔  Move side-loaded test data /sdcard -> /sdcard/gtestdata

Will try to land again tomorrow morning.

[agrieve, 2016-05-27 02:51:52]

agrieve@chromium.org changed reviewers:
+ torne@chromium.org

[agrieve, 2016-05-27 02:51:52]

torne@chromium.org: Please review changes in android_webview

[agrieve, 2016-05-27 02:52:04]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 02:52:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018663002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018663002/280001

[commit-bot: I haz the power, 2016-05-27 02:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 02:54:44]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Torne, 2016-05-27 09:47:46]

android_webview LGTM

[agrieve, 2016-05-27 14:15:21]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-05-27 14:15:22]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2018663002/#ps300001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-27 14:15:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018663002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018663002/300001

[commit-bot: I haz the power, 2016-05-27 15:58:10]

Description was changed from

==========
Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
==========

to

==========
Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
==========

[commit-bot: I haz the power, 2016-05-27 15:58:11]

Committed patchset #3 (id:300001)

[commit-bot: I haz the power, 2016-05-27 16:00:43]

Description was changed from

==========
Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
==========

to

==========
Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root

Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)

And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.

TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169

Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
Cr-Commit-Position: refs/heads/master@{#396479}
==========

[commit-bot: I haz the power, 2016-05-27 16:00:44]

Patchset 3 (id:??) landed as
https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
Cr-Commit-Position: refs/heads/master@{#396479}

[johnme, 2016-06-03 15:50:33]

On 2016/05/27 16:00:44, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> Cr-Commit-Position: refs/heads/master@{#396479}

Since this has landed, one of the following three has failed on every build of
asan-clang-phone:
- FileSystemBrowserTestWithLowQuota.QuotaTest
- IndexedDBBrowserTest.DeleteCompactsBackingStore
- IndexedDBBrowserTest.GetAllMaxMessageSize

Could that be related to this patch?

First failure:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-cl...

Nothing else on the blamelist seems at all related:
https://chromium.googlesource.com/chromium/src.git/+log/e7094a6c52fd5bf3c3735...

[agrieve, 2016-06-03 16:10:43]

On 2016/06/03 15:50:33, johnme wrote:
> On 2016/05/27 16:00:44, commit-bot: I haz the power wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> > Cr-Commit-Position: refs/heads/master@{#396479}
> 
> Since this has landed, one of the following three has failed on every build of
> asan-clang-phone:
> - FileSystemBrowserTestWithLowQuota.QuotaTest
> - IndexedDBBrowserTest.DeleteCompactsBackingStore
> - IndexedDBBrowserTest.GetAllMaxMessageSize
> 
> Could that be related to this patch?
> 
> First failure:
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-cl...
> 
> Nothing else on the blamelist seems at all related:
>
https://chromium.googlesource.com/chromium/src.git/+log/e7094a6c52fd5bf3c3735...

I notice this as well when I was sheriffing earlier this week. Filed
https://bugs.chromium.org/p/chromium/issues/detail?id=616155
AFAICT, those tests don't use test data files, which is what this change
affects. They also pass some of the time on other bots rather than always fail,
so I don't it's because of changing the location of the test data files.

[agrieve, 2016-06-06 20:14:00]

A revert of this CL (patchset #3 id:300001) has been created in
https://codereview.chromium.org/2044523003/ by agrieve@chromium.org.

The reason for reverting is: Breaking quota-related tests in
content_browsertests
https://crbug.com/617213.