Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4077)

Unified Diff: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java

Issue 2043803003: 👔 Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase atop https://codereview.chromium.org/2041723006 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
diff --git a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
index 77264b3de60594e30ea2caaae8ea94bcfe9450d9..f71d0cd47b897c036780f0efae07f6256d2de769 100644
--- a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
+++ b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
@@ -6,7 +6,7 @@ package org.chromium.components_browsertests_apk;
import android.os.Bundle;
-import org.chromium.base.PathUtils;
+import org.chromium.base.test.util.UrlUtils;
import org.chromium.content_shell.browsertests.ContentShellBrowserTestActivity;
import java.io.File;
@@ -24,7 +24,9 @@ public class ComponentsBrowserTestsActivity extends ContentShellBrowserTestActiv
@Override
protected File getPrivateDataDirectory() {
- return new File(PathUtils.getExternalStorageDirectory(),
+ // TODO(agrieve): We should not be touching the side-loaded test data directory.
+ // https://crbug.com/617734
+ return new File(UrlUtils.getIsolatedTestRoot(),
ComponentsBrowserTestsApplication.PRIVATE_DATA_DIRECTORY_SUFFIX);
}

Powered by Google App Engine
This is Rietveld 408576698