Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2041723006: 💻 Fix build/apk_test.gypi since webrtc still requires it. (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build/apk_test.gypi since webrtc still requires it. It was broken by https://codereview.chromium.org/1975153003 BUG=webrtc:5956 Committed: https://crrev.com/36409f70bd88b63079bebd69e4871e89e7d09756 Cr-Commit-Position: refs/heads/master@{#398295}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M build/android/jinja_template.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/apk_test.gypi View 1 1 chunk +37 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
agrieve
On 2016/06/07 02:00:06, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:kjellander@chromium.org Luckily, I had ...
4 years, 6 months ago (2016-06-07 02:01:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041723006/1
4 years, 6 months ago (2016-06-07 02:02:28 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/16998) ios-device-gn on ...
4 years, 6 months ago (2016-06-07 02:04:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041723006/20001
4 years, 6 months ago (2016-06-07 02:48:34 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/82992)
4 years, 6 months ago (2016-06-07 04:03:14 UTC) #11
kjellander_chromium
lgtm Thanks for doing this. I'm working hard to take us over to GN right ...
4 years, 6 months ago (2016-06-07 05:38:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041723006/20001
4 years, 6 months ago (2016-06-07 13:59:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 14:24:19 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 14:25:35 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36409f70bd88b63079bebd69e4871e89e7d09756
Cr-Commit-Position: refs/heads/master@{#398295}

Powered by Google App Engine
This is Rietveld 408576698