Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2043303004: More WaitableEvent stragglers migrated to enum-based constructor (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews, ozone-reviews_chromium.org, kalyank, posciak+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, piman+watch_chromium.org, alokp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_4_misc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More WaitableEvent stragglers migrated to enum-based constructor Previous manual regex was finding "new WaitableEvent(...)" and "...event_(...)", i.e. heap allocs and initializer lists but was missing stack variables. This change uses the following regex to catch those and manually fix them: "WaitableEvent\ [\w]+\((true|false)," Also fixed missing space presubmit error in media_message_fifo_unittest.cc BUG=612843 R=fdoray@chromium.org TBR=danakj@chromium.org Committed: https://crrev.com/fd84d02f5300d4659644d19912bbb964cd6d5a95 Cr-Commit-Position: refs/heads/master@{#398868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chrome/browser/android/provider/run_on_ui_thread_blocking.h View 1 chunk +3 lines, -1 line 0 comments Download
M chromecast/base/bind_to_task_runner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/media/base/media_resource_tracker_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromecast/media/cma/ipc/media_message_fifo_unittest.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M components/exo/wayland/server_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/cras/cras_input_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/cras/cras_unified_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/proxy_helpers.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
gab
As for previous ones, sending to CQ with TBR danakj. Francois please double check me ...
4 years, 6 months ago (2016-06-09 12:56:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043303004/1
4 years, 6 months ago (2016-06-09 12:56:14 UTC) #6
fdoray
lgtm
4 years, 6 months ago (2016-06-09 13:25:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:18:26 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 14:18:33 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd84d02f5300d4659644d19912bbb964cd6d5a95 Cr-Commit-Position: refs/heads/master@{#398868}
4 years, 6 months ago (2016-06-09 14:20:21 UTC) #12
danakj
4 years, 6 months ago (2016-06-09 18:42:31 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698