chromecast/base/bind_to_task_runner_unittest.cc - Issue 2043303004: More WaitableEvent stragglers migrated to enum-based constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/base/bind_to_task_runner_unittest.cc

Issue 2043303004: More WaitableEvent stragglers migrated to enum-based constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d_4_misc

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/provider/run_on_ui_thread_blocking.h ('k') | chromecast/media/base/media_resource_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/base/bind_to_task_runner_unittest.cc

diff --git a/chromecast/base/bind_to_task_runner_unittest.cc b/chromecast/base/bind_to_task_runner_unittest.cc

index b2148095147927ecb2d1ca7783a07d1effe964d1..753fd1c0f78f14a6eec51f6e9bc86285a4ae910f 100644

--- a/chromecast/base/bind_to_task_runner_unittest.cc

+++ b/chromecast/base/bind_to_task_runner_unittest.cc

@@ -49,7 +49,8 @@ class BindToTaskRunnerTest : public ::testing::Test {

TEST_F(BindToTaskRunnerTest, Closure) {

// Test the closure is run inside the loop, not outside it.

- base::WaitableEvent waiter(false, false);

+ base::WaitableEvent waiter(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::Closure cb = BindToCurrentThread(

base::Bind(&base::WaitableEvent::Signal, Unretained(&waiter)));

cb.Run();