Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2054613002: Manual refactor of few more stragglers to enum-based WaitableEvent constructor. (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews, ozone-reviews_chromium.org, tzik, Lei Zhang, dzhioev+watch_chromium.org, achuith+watch_chromium.org, nhiroki, tommycli, oshima+watch_chromium.org, kalyank, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_3_webkit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual refactor of few more stragglers to enum-based WaitableEvent constructor. Found a couple more sites with regex "(WaitableEvent|event_)\((true|false),", hoping those are the last ones..! BUG=612843 R=fdoray@chromium.org TBR=danakj@chromium.org (Francois please fact check me, I'm TBRing dana for otherwise mechanical change) Committed: https://crrev.com/4d5284c4618a9f95cbe7cb60709432db05b38e68 Cr-Commit-Position: refs/heads/master@{#398766}

Patch Set 1 #

Patch Set 2 : caught one more with event_\( instead of _event_\( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M base/mac/mach_port_broker_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/wayland/fake_server.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
gab
TBR : Francois please do fact check me post-commit since those are manual, but I ...
4 years, 6 months ago (2016-06-09 01:45:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054613002/1
4 years, 6 months ago (2016-06-09 01:46:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054613002/20001
4 years, 6 months ago (2016-06-09 01:52:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 02:52:51 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4d5284c4618a9f95cbe7cb60709432db05b38e68 Cr-Commit-Position: refs/heads/master@{#398766}
4 years, 6 months ago (2016-06-09 02:55:15 UTC) #13
danakj
4 years, 6 months ago (2016-06-09 18:51:35 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698