Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5306)

Unified Diff: chromecast/media/cma/ipc/media_message_fifo_unittest.cc

Issue 2043303004: More WaitableEvent stragglers migrated to enum-based constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d_4_misc
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/base/media_resource_tracker_unittest.cc ('k') | components/exo/wayland/server_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/cma/ipc/media_message_fifo_unittest.cc
diff --git a/chromecast/media/cma/ipc/media_message_fifo_unittest.cc b/chromecast/media/cma/ipc/media_message_fifo_unittest.cc
index 764e4b4b8b79e5a66368f5b96719b2d95b5a9980..229e2375632d026b9bc799c2b6adb50d6332fa1e 100644
--- a/chromecast/media/cma/ipc/media_message_fifo_unittest.cc
+++ b/chromecast/media/cma/ipc/media_message_fifo_unittest.cc
@@ -54,7 +54,7 @@ void MsgProducer(std::unique_ptr<MediaMessageFifo> fifo,
if (msg1)
break;
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10));
- } while(true);
+ } while (true);
}
fifo.reset();
@@ -78,7 +78,7 @@ void MsgConsumer(std::unique_ptr<MediaMessageFifo> fifo,
break;
}
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10));
- } while(true);
+ } while (true);
}
fifo.reset();
@@ -133,7 +133,8 @@ TEST(MediaMessageFifoTest, AlternateWriteRead) {
new FifoMemoryChunk(&buffer[0], buffer_size)),
false));
- base::WaitableEvent event(false, false);
+ base::WaitableEvent event(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
thread->task_runner()->PostTask(
FROM_HERE, base::Bind(&MsgProducerConsumer, base::Passed(&producer_fifo),
base::Passed(&consumer_fifo), &event));
@@ -163,8 +164,12 @@ TEST(MediaMessageFifoTest, MultiThreaded) {
new FifoMemoryChunk(&buffer[0], buffer_size)),
false));
- base::WaitableEvent producer_event_done(false, false);
- base::WaitableEvent consumer_event_done(false, false);
+ base::WaitableEvent producer_event_done(
+ base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
+ base::WaitableEvent consumer_event_done(
+ base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
const int msg_count = 2048;
producer_thread->task_runner()->PostTask(
« no previous file with comments | « chromecast/media/base/media_resource_tracker_unittest.cc ('k') | components/exo/wayland/server_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698