Replace info.This() with info.Holder()

Replace info.This() with info.Holder()

If the object is not window, info.This() == info.Holder(). Hence, we can just replace
info.This() with info.Holder().

If the object is window, info.Holder() is the inner window and info.This() is the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.

BUG=

Committed: https://crrev.com/22af33ec38578537487b405149b46c80e984e2e4
Cr-Commit-Position: refs/heads/master@{#398249}

[haraken, 2016-06-07 02:43:50]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org, yukishiino@chromium.org

[haraken, 2016-06-07 02:43:51]

PTAL

[Yuki, 2016-06-07 05:16:09]

I understand that you'd like to avoid any confusion between info.This() and
info.Holder(), but I'm a bit uneasy with [CallWith=HolderObject].  For the most
developers who are not familiar with V8 APIs, I think [CallWith=ThisValue] makes
much more sense than [CallWith=HolderObject].  I'd prefer keeping the old name
in IDLs.

Another point about [CallWith=ThisValue] is that it's only used at Location's
valueOf().  Do we really want to support [CallWith=ThisValue] ?  To me, it seems
that [Custom] does the trick and it works better than [CallWith=ThisValue]
because we don't need origin-check in this case.

My preferences are:
1) Retire [CallWith=ThisValue].
2) Keep the old name as [CallWith=ThisValue].
3) If we're going to change the name to [CallWith=HolderObject], then let's
update a comment in Location.h, too.

[haraken, 2016-06-07 05:40:58]

On 2016/06/07 05:16:09, Yuki wrote:
> I understand that you'd like to avoid any confusion between info.This() and
> info.Holder(), but I'm a bit uneasy with [CallWith=HolderObject].  For the
most
> developers who are not familiar with V8 APIs, I think [CallWith=ThisValue]
makes
> much more sense than [CallWith=HolderObject].  I'd prefer keeping the old name
> in IDLs.
> 
> Another point about [CallWith=ThisValue] is that it's only used at Location's
> valueOf().  Do we really want to support [CallWith=ThisValue] ?  To me, it
seems
> that [Custom] does the trick and it works better than [CallWith=ThisValue]
> because we don't need origin-check in this case.
> 
> My preferences are:
> 1) Retire [CallWith=ThisValue].
> 2) Keep the old name as [CallWith=ThisValue].
> 3) If we're going to change the name to [CallWith=HolderObject], then let's
> update a comment in Location.h, too.

At the moment, took the approach 2).

[Yuki, 2016-06-07 06:08:49]

LGTM!

[haraken, 2016-06-07 06:21:55]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-06-07 06:22:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943002/20001

[commit-bot: I haz the power, 2016-06-07 06:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 06:53:36]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[haraken, 2016-06-07 06:57:21]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-06-07 06:57:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943002/20001

[commit-bot: I haz the power, 2016-06-07 07:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 07:20:38]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[haraken, 2016-06-07 07:36:52]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-06-07 07:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943002/20001

[commit-bot: I haz the power, 2016-06-07 08:11:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 08:13:21]

Description was changed from

==========
Replace info.This() with info.Holder()

If the object is not window, info.This() == info.Holder(). Hence, we can just
replace
info.This() with info.Holder().

If the object is window, info.Holder() is the inner window and info.This() is
the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.

BUG=
==========

to

==========
Replace info.This() with info.Holder()

If the object is not window, info.This() == info.Holder(). Hence, we can just
replace
info.This() with info.Holder().

If the object is window, info.Holder() is the inner window and info.This() is
the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.

BUG=

Committed: https://crrev.com/22af33ec38578537487b405149b46c80e984e2e4
Cr-Commit-Position: refs/heads/master@{#398249}
==========

[commit-bot: I haz the power, 2016-06-07 08:13:22]

Patchset 2 (id:??) landed as
https://crrev.com/22af33ec38578537487b405149b46c80e984e2e4
Cr-Commit-Position: refs/heads/master@{#398249}