Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2042943002: Replace info.This() with info.Holder() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index d4c68676ae8add9f32179f647adadd0845fb8922..942680906095a013b21eadb225a693c9d78cf814 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -146,12 +146,12 @@ void V8Window::openerAttributeSetterCustom(v8::Local<v8::Value> value, const v8:
toLocalFrame(impl->frame())->loader().setOpener(0);
}
- // Delete the accessor from this object.
+ // Delete the accessor from the inner object.
info.Holder()->Delete(isolate->GetCurrentContext(), v8AtomicString(isolate, "opener"));
- // Put property on the front (this) object.
- if (info.This()->IsObject()) {
- v8::Maybe<bool> unused = v8::Local<v8::Object>::Cast(info.This())->Set(isolate->GetCurrentContext(), v8AtomicString(isolate, "opener"), value);
+ // Put property on the inner object.
+ if (info.Holder()->IsObject()) {
+ v8::Maybe<bool> unused = v8::Local<v8::Object>::Cast(info.Holder())->Set(isolate->GetCurrentContext(), v8AtomicString(isolate, "opener"), value);
ALLOW_UNUSED_LOCAL(unused);
}
}

Powered by Google App Engine
This is Rietveld 408576698