third_party/WebKit/Source/bindings/scripts/v8_utilities.py - Issue 2042943002: Replace info.This() with info.Holder()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2042943002: Replace info.This() with info.Holder() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

index e934c986ad2ad5f3dc454be4b2e97b8469a1cd61..a48586d949a4556c7422676e7edf2c697e74a3f6 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

@@ -200,7 +200,7 @@ CALL_WITH_ARGUMENTS = {

'CurrentWindow': 'currentDOMWindow(info.GetIsolate())',

'EnteredWindow': 'enteredDOMWindow(info.GetIsolate())',

'Document': 'document',

- 'ThisValue': 'ScriptValue(scriptState, info.This())',

+ 'ThisValue': 'ScriptValue(scriptState, info.Holder())',

}

# List because key order matters, as we want arguments in deterministic order

CALL_WITH_VALUES = [