third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp - Issue 2042943002: Replace info.This() with info.Holder()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

Issue 2042943002: Replace info.This() with info.Holder() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

index 27dd511c9674261e29fe950bb769a4ed36fa4615..ef34d64cdd4cd65a3e66307062a25780b4eb7f9b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

@@ -58,7 +58,7 @@ void V8ObjectConstructor::isValidConstructorMode(const v8::FunctionCallbackInfo<

V8ThrowException::throwTypeError(info.GetIsolate(), "Illegal constructor");

return;

}

- v8SetReturnValue(info, info.This());

+ v8SetReturnValue(info, info.Holder());

}

} // namespace blink

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | no next file with comments »