Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.

Committed: https://crrev.com/2240d4ba98b66142a38137ef431b325d2d4fd377
Cr-Commit-Position: refs/heads/master@{#398965}

[rwlbuis, 2016-06-07 18:37:26]

Description was changed from

==========
isColorKeyword WIP

BUG=
==========

to

==========
Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.
==========

[rwlbuis, 2016-06-07 18:38:48]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-06-07 18:38:48]

PTAL.

BTW I am open to name suggestions to avoid possible conflicts, maybe
isColorCSSKeyword or is CSSColorKeyword?

[Timothy Loh, 2016-06-08 03:20:16]

I'm not sure this is really the right place for the function but I don't have
any better suggestions right now. It's an improvement though, so lgtm.

[Timothy Loh, 2016-06-08 03:21:11]

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
(right):

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:9:
#include "core/css/parser/CSSPropertyParser.h"
no longer needed

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:64:
ASSERT(CSSPropertyParser::isColorKeyword(keyword));
needs to be updated

[rwlbuis, 2016-06-08 23:08:39]

Sorry about that, but it occurred to me that StyleColor may be a better place.
So it is basically a choice between patch set 3 and 4, let me know :)

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
(right):

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:9:
#include "core/css/parser/CSSPropertyParser.h"
On 2016/06/08 03:21:11, Timothy Loh wrote:
> no longer needed

Done.

https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:64:
ASSERT(CSSPropertyParser::isColorKeyword(keyword));
On 2016/06/08 03:21:11, Timothy Loh wrote:
> needs to be updated

Done. Also made it a DCHECK since the style check suggested it.

[Timothy Loh, 2016-06-09 04:54:53]

On 2016/06/08 23:08:39, rwlbuis wrote:
> Sorry about that, but it occurred to me that StyleColor may be a better place.
> So it is basically a choice between patch set 3 and 4, let me know :)
> 
>
https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
> (right):
> 
>
https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:9:
> #include "core/css/parser/CSSPropertyParser.h"
> On 2016/06/08 03:21:11, Timothy Loh wrote:
> > no longer needed
> 
> Done.
> 
>
https://codereview.chromium.org/2041363002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp:64:
> ASSERT(CSSPropertyParser::isColorKeyword(keyword));
> On 2016/06/08 03:21:11, Timothy Loh wrote:
> > needs to be updated
> 
> Done. Also made it a DCHECK since the style check suggested it.

StyleColor sgtm

[rwlbuis, 2016-06-09 09:33:45]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-06-09 09:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2041363002/#ps60001
(title: "Alternative using StyleColor")

[commit-bot: I haz the power, 2016-06-09 09:34:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041363002/60001

[commit-bot: I haz the power, 2016-06-09 14:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 14:44:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rwlbuis, 2016-06-09 16:56:09]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-06-09 16:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041363002/60001

[commit-bot: I haz the power, 2016-06-09 18:46:42]

Description was changed from

==========
Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.
==========

to

==========
Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.
==========

[commit-bot: I haz the power, 2016-06-09 18:46:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-09 18:48:15]

Description was changed from

==========
Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.
==========

to

==========
Move isColorKeyword out of CSSPropertyParser

Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.

Committed: https://crrev.com/2240d4ba98b66142a38137ef431b325d2d4fd377
Cr-Commit-Position: refs/heads/master@{#398965}
==========

[commit-bot: I haz the power, 2016-06-09 18:48:17]

Patchset 4 (id:??) landed as
https://crrev.com/2240d4ba98b66142a38137ef431b325d2d4fd377
Cr-Commit-Position: refs/heads/master@{#398965}