third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp - Issue 2041363002: Move isColorKeyword out of CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 2041363002: Move isColorKeyword out of CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alternative using StyleColor Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

index 5c5a08e7b9810370e738bfead09114a3eb0710c9..6eb6b0fedd7d900d4b9a5953ef24ec2563c24d96 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -10,6 +10,7 @@

#include "core/css/CSSInheritedValue.h"

#include "core/css/CSSInitialValue.h"

#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/StyleColor.h"

#include "core/css/parser/CSSParserIdioms.h"

#include "core/css/parser/CSSPropertyParser.h"

#include "core/html/parser/HTMLParserIdioms.h"

@@ -443,7 +444,7 @@ CSSValue* CSSParserFastPaths::parseColor(const String& string, CSSParserMode par

{

ASSERT(!string.isEmpty());

CSSValueID valueID = cssValueKeywordID(string);

- if (CSSPropertyParser::isColorKeyword(valueID)) {

+ if (StyleColor::isColorKeyword(valueID)) {

if (!isValueAllowedInMode(valueID, parserMode))

return nullptr;

return CSSPrimitiveValue::createIdentifier(valueID);