third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp - Issue 2041363002: Move isColorKeyword out of CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2041363002: Move isColorKeyword out of CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alternative using StyleColor Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

index 7467c610b3ca6b023483e32c2fc81298ca8d2b67..b4e834106660a9cb4b98eda4312a4ca50f1b1f57 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -8,8 +8,6 @@

#include "core/css/CSSColorValue.h"

#include "core/css/CSSStringValue.h"

#include "core/css/CSSValuePair.h"

-// TODO(timloh): Remove this dependency

-#include "core/css/parser/CSSPropertyParser.h"

namespace blink {

@@ -447,7 +445,7 @@ static bool parseColorFunction(CSSParserTokenRange& range, RGBA32& result)

CSSValue* consumeColor(CSSParserTokenRange& range, CSSParserMode cssParserMode, bool acceptQuirkyColors)

{

CSSValueID id = range.peek().id();

- if (CSSPropertyParser::isColorKeyword(id)) {

+ if (StyleColor::isColorKeyword(id)) {

if (!isValueAllowedInMode(id, cssParserMode))

return nullptr;

return consumeIdent(range);