Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2041363002: Move isColorKeyword out of CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Alternative using StyleColor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index 98f39d2d96dffe80302d39b4bd0233039fde57db..9fc919005f8c0fdf5e9c0cae141634d7a31317da 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -180,35 +180,6 @@ bool CSSPropertyParser::parseValueStart(CSSPropertyID unresolvedProperty, bool i
return false;
}
-bool CSSPropertyParser::isColorKeyword(CSSValueID id)
-{
- // Named colors and color keywords:
- //
- // <named-color>
- // 'aqua', 'black', 'blue', ..., 'yellow' (CSS3: "basic color keywords")
- // 'aliceblue', ..., 'yellowgreen' (CSS3: "extended color keywords")
- // 'transparent'
- //
- // 'currentcolor'
- //
- // <deprecated-system-color>
- // 'ActiveBorder', ..., 'WindowText'
- //
- // WebKit proprietary/internal:
- // '-webkit-link'
- // '-webkit-activelink'
- // '-internal-active-list-box-selection'
- // '-internal-active-list-box-selection-text'
- // '-internal-inactive-list-box-selection'
- // '-internal-inactive-list-box-selection-text'
- // '-webkit-focus-ring-color'
- // '-internal-quirk-inherit'
- //
- return (id >= CSSValueAqua && id <= CSSValueInternalQuirkInherit)
- || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen)
- || id == CSSValueMenu;
-}
-
bool CSSPropertyParser::isSystemColor(CSSValueID id)
{
return (id >= CSSValueActiveborder && id <= CSSValueWindowtext) || id == CSSValueMenu;

Powered by Google App Engine
This is Rietveld 408576698