Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2041283002: Replace targetHasUnifiedMultisampling in GrPB constructor (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixdash
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace targetHasUnifiedMultisampling in GrPB constructor Replaces targetHasUnifiedMultisampling with a simpler "useHWAA". Now the code that creates a pipeline builder needs to decide on its own whether it should enable multisampling, rather than relying on the builder to try and guess. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041283002 Committed: https://skia.googlesource.com/skia/+/ecbc12b1c1c72de0cf7bba4a3f6a7cce4f43bf41

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -93 lines) Patch
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrDrawContext.h View 3 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 21 chunks +48 lines, -39 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 5 chunks +8 lines, -20 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
csmartdalton
4 years, 6 months ago (2016-06-07 07:01:39 UTC) #3
csmartdalton
4 years, 6 months ago (2016-06-08 02:12:11 UTC) #4
bsalomon
lgtm
4 years, 6 months ago (2016-06-08 13:27:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041283002/20001
4 years, 6 months ago (2016-06-08 16:45:58 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 17:08:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ecbc12b1c1c72de0cf7bba4a3f6a7cce4f43bf41

Powered by Google App Engine
This is Rietveld 408576698