Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2043203004: Fix instances where hwaa was wrong for mixed samples (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix instances where hwaa was wrong for mixed samples Fixes a bug with coverage-AA hairlines where hwaa was unintentionally enabled for mixed samples, and a bug with path stenciling where hwaa was unintentionally disabled for mixed samples. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043203004 Committed: https://skia.googlesource.com/skia/+/7942f22c607caf826a6a609b89338a569d0a30e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
csmartdalton
One more... Robert, I have it in my mind that you're the one to throw ...
4 years, 6 months ago (2016-06-08 02:10:06 UTC) #3
bsalomon
Rob is on vacation until 6/22. This lgtm.
4 years, 6 months ago (2016-06-08 13:26:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043203004/1
4 years, 6 months ago (2016-06-08 16:19:00 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 16:32:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7942f22c607caf826a6a609b89338a569d0a30e7

Powered by Google App Engine
This is Rietveld 408576698