Implement the Sync promo in the password bubble on Mac.

Implement the Sync promo in the password bubble on Mac.

BUG=615825
Committed: https://crrev.com/73dc7a161bcc1525c3fea37ef9991de7e3331664
Cr-Commit-Position: refs/heads/master@{#399179}

[vasilii, 2016-06-09 18:08:01]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-06-09 18:08:02]

Hi Vaclav,

please review.

[vabr (Chromium), 2016-06-10 07:17:00]

On 2016/06/09 18:08:02, vasilii wrote:
> Hi Vaclav,
> 
> please review.

Hi Vasilii,

I'll try to have a look today. I have two more large CLs to review, so it might
get a little delayed.

Cheers,
Vaclav

[vabr (Chromium), 2016-06-10 13:54:59]

Thanks, Vasilii, this LGTM.
Vaclav

https://codereview.chromium.org/2040143006/diff/20001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2040143006/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm:80:
SetUpManageState({&form1, &form2});
I like the brevity of the initializer list!

[vasilii, 2016-06-10 14:35:13]

Thanks for the smooth review!

https://codereview.chromium.org/2040143006/diff/20001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2040143006/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm:80:
SetUpManageState({&form1, &form2});
On 2016/06/10 13:54:59, vabr (Chromium) wrote:
> I like the brevity of the initializer list!

+1

[vasilii, 2016-06-10 14:35:17]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-06-10 14:35:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040143006/20001

[commit-bot: I haz the power, 2016-06-10 14:39:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-10 14:42:27]

Description was changed from

==========
Implement the Sync promo in the password bubble on Mac.

BUG=615825
==========

to

==========
Implement the Sync promo in the password bubble on Mac.

BUG=615825

Committed: https://crrev.com/73dc7a161bcc1525c3fea37ef9991de7e3331664
Cr-Commit-Position: refs/heads/master@{#399179}
==========

[commit-bot: I haz the power, 2016-06-10 14:42:27]

Patchset 2 (id:??) landed as
https://crrev.com/73dc7a161bcc1525c3fea37ef9991de7e3331664
Cr-Commit-Position: refs/heads/master@{#399179}