Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

Issue 2040143006: Implement the Sync promo in the password bubble on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
diff --git a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
index d371e581dad6dc0b6e1b8ed92d601a58255a7713..8e1868f82094e316a005194b4c2231592a1aee37 100644
--- a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
+++ b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
@@ -38,6 +38,7 @@ void ManagePasswordsControllerTest::SetUp() {
profile(), password_manager::BuildPasswordStore<
content::BrowserContext,
testing::NiceMock<password_manager::MockPasswordStore>>);
+ delegate_.reset([[ContentViewDelegateMock alloc] init]);
}
ManagePasswordsBubbleModel*
@@ -45,6 +46,7 @@ ManagePasswordsControllerTest::GetModelAndCreateIfNull() {
if (!model_) {
model_.reset(new ManagePasswordsBubbleModel(test_web_contents_.get(),
GetDisplayReason()));
+ [delegate() setModel:model_.get()];
}
return model_.get();
}
@@ -92,8 +94,8 @@ void ManagePasswordsControllerTest::SetUpConfirmationState() {
ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(ui_controller_));
}
-void ManagePasswordsControllerTest::SetUpManageState() {
- std::vector<const autofill::PasswordForm*> forms;
+void ManagePasswordsControllerTest::SetUpManageState(
+ const VectorConstFormPtr& forms) {
EXPECT_CALL(*ui_controller_, GetCurrentForms()).WillOnce(ReturnRef(forms));
GURL origin(kSiteOrigin);
EXPECT_CALL(*ui_controller_, GetOrigin()).WillOnce(ReturnRef(origin));
@@ -117,4 +119,7 @@ ManagePasswordsControllerTest::GetDisplayReason() const {
_dismissed = YES;
}
+- (void)refreshBubble {
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698